Fix race condition in group.set #18796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
integration: group
core
small-pr
ghost
assigned 
marchingphoenix
approved these changes
Nov 29, 2018
42B
reviewed
Nov 29, 2018
| await async_setup_component(hass, 'group', {}) | ||
| component = EntityComponent(_LOGGER, DOMAIN, hass, group_name='yo') | ||
|
|
||
| for i in range(2): |
balloob
added a commit
that referenced
this pull request
Nov 29, 2018
This was referenced Nov 29, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Wraps group.set service in an async lock. Group.set contains a few awaits, which can cause a race condition and trying to create a group twice.
Related issue (if applicable): fixes #18636
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: